When selecting a language in the Content Language Selector, the Topic List is not filtered as expected.

lisa.wuxf · April 22, 2023, 6:48pm

Environment

Discourse Version: 3.1.0.beta4 ( 9858171f3c )

Plugin Commit: 59049eb2

Steps to Reproduce

enable and set up content languages
tag some topics with different content language tags
try to select a language tag from the content languages drop down
it doesn’t filter as expected

Example

https://lisaoflife.com/latest

Logs

The resource https://lisaoflife.com/assets/onpopstate-handler-ece5c756a2e952d484f91ce9faefcf87d7660f2102e26047221987c335ff8c11.js was preloaded using link preload but not used within a few seconds from the window’s load event. Please make sure it has an appropriate as value and it is preloaded intentionally.

merefield · April 23, 2023, 6:49am

Actually, we looked at this in more depth, and I think it’s basically not broken, it’s simply not that intuitive. The documentation should be improved. I’d forgotten how it works and had to remind myself by looking at the code.

The resulting list of language tags are not selected individually but are used as the set of language tags that determine what topics are shown.

So clicking on a single language tag in the drop down doesn’t appear to filter the topic list by that specific tag and nor is this intended:

github.com

paviliondev/discourse-multilingual/blob/59049eb240f84acb2534321ca008dc34c68a59dd/plugin.rb#L308


      
                  topic,
                  content_language_tags
                )
                creator.rollback_from_errors!(topic)
              end
          
          
    Multilingual::ContentTag.update_topic(topic, content_language_tags)
            end
          end
          
          
TopicQuery.add_custom_filter(:content_languages) do |result, query|
            if Multilingual::ContentLanguage.topic_filtering_enabled
              content_languages = query.user ?
                                  query.user.content_languages :
                                  [*query.options[:content_languages]]
          
          
    if content_languages.present? && content_languages.any?
                result = result.joins(:tags).where("tags.name in (?)", content_languages)
              end
            end

As an Admin, if you wish to use the whole Topic List as a way of checking through for untagged content languages, you must first clear the Content Language selection from your User Preferences.

I think the actions here should be:

improve the documentation.
document the functionality as part of a front end test.

tagging this as #low

matenauta · April 28, 2023, 2:12pm

I reported the same on Meta, it’s a kind of ‘not’ from UI/UX perspective (!)

With full respect, I don’t feel that’s low because transmit the sentiment the plugin don’t work.

And that push eventually customers away (probably fits better on #mid or something)

There is a better workaround than hide the not-filter from CSS?

merefield · April 28, 2023, 2:15pm

yeah, it probably should be a different kind of control