Resolve deprecations (before it breaks)

Support Discourse Custom Wizard
,
1

There are a lot of deprecations showing for the front end code. We can either wait till they break and resolve it under too much time pressure, or act on them right now.

            {"type":"warn","text":"DEPRECATION: Calling transitionTo on a route is deprecated. Use the RouterService instead. [deprecation id: routing.transition-methods] See https://deprecations.emberjs.com/v3.x/#toc_routing-transition-methods for more details."}
            {"type":"warn","text":"[PLUGIN test] Deprecation notice: Defining modals using a controller is deprecated. Use the component-based API instead. (modal: next-session-scheduled) [deprecated since Discourse 3.1] [removal in Discourse 3.2] [deprecation id: discourse.modal-controllers] [info: https://meta.discourse.org/t/268057]"}
            {"type":"warn","text":"DEPRECATION: The `action.type` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-custom-action.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.action.type}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `action.run_after` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-custom-action.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.action.run_after}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `action.run_after` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-custom-action.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.action.run_after}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `action.title` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-custom-action.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.action.title}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `action.post` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-custom-action.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.action.post}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `action.post` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-custom-action.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.action.post}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `action.post_builder` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-custom-action.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.action.post_builder}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `action.category` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-custom-action.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.action.category}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `action.tags` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-custom-action.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.action.tags}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `action.visible` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-custom-action.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.action.visible}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `action.custom_fields` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-custom-action.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.action.custom_fields}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `action.profile_updates` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-custom-action.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.action.profile_updates}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `action.url` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-custom-action.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.action.url}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `input.type` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-mapper-input.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.input.type}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `input` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-mapper-input.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.input}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `input.type` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-mapper-input.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.input.type}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `input.output` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-mapper-input.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.input.output}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `input.output_type` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-mapper-input.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.input.output_type}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `input.pairs` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-mapper-input.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.input.pairs}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: The `input.output_connector` property path was used in the `discourse/plugins/discourse-custom-wizard/discourse/templates/components/wizard-mapper-input.hbs` template without using `this`. This fallback behavior has been deprecated, all properties must be looked up on `this` when used in the template: {{this.input.output_connector}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details."}
            {"type":"warn","text":"DEPRECATION: Calling transitionTo on a route is deprecated. Use the RouterService instead. [deprecation id: routing.transition-methods] See https://deprecations.emberjs.com/v3.x/#toc_routing-transition-methods for more details."}
2 Likes
2

Assigning this to me.

2 Likes
6

(changed the assignment from post level to topic level otherwise it breaks reporting)

1 Like
7

Thanks. Yeah weird for some reason I couldn’t assign at topic level.

8

Do we need to assign at the post level, or just topic level? Perhaps we should hide the post assign option as I’m sure I’ve done this by mistake too.

There doesn’t seem to be a setting to make it just Topic level assigns, but there is an assign-post class so hiding it should be easy.

1 Like
9

I think it was early and I was using wrench drop-down instead of the button. :sweat_smile:

1 Like
10

I’ve just hidden these with CSS in our theme:

span.extra-buttons button.assign-post {
        display: none;
}
1 Like
11

OK that was quite a lot more than I originally bargained for.

Nonetheless, here’s the PR:

Pending review.

1 Like
12

One minor change and this will be merged.

1 Like
13

Resolved! //unintentional

14

Please let me know if you become aware of any negative impact of this change and I will take a look.

17

Still seeing one

[PLUGIN discourse-custom-wizard] Deprecation notice: Importing getOwner from `discourse-common/lib/get-owner` is deprecated. Use `import { getOwner } from '@ember/application'`, or if you still need the fallback shim, use `import { getOwnerWithFallback } from 'discourse-common/lib/get-owner';`. [deprecated since Discourse 3.2] [deprecation id: discourse.get-owner-with-fallback]

CW 578c92e90e0275677e529d7a488970ae52243ba2
Discourse 76e5a939d4d24c95ddaa6c4f1db1f2bc09330187

18

Probably a new one