Rebuild Failing

[davidkingham]

Environment

Discourse Version: v3.2.0.beta3 +450

Plugin Commit: latest, currently uninstalled

Steps to Reproduce

Rebuild fails with custom wizard enabled

Example

Logs

I, [2023-12-08T02:58:28.187645 #1] INFO – : > cd /var/www/discourse && su discourse -c ‘bundle exec rake db:migrate’
Plugin name is ‘discourse-custom-email-digest-enabled’, but plugin directory is named ‘discourse-custom-email-digest’
rake aborted!
Gem::LoadError: can’t activate discourse_subscription_client-0.1.0.pre15, already activated discourse_subscription_client-0.1.1 (Gem::LoadError)
/var/www/discourse/lib/plugin_gem.rb:25:in load' /var/www/discourse/lib/plugin/instance.rb:848:in gem’
/var/www/discourse/plugins/discourse-subscription-client/plugin.rb:13:in activate!' /var/www/discourse/lib/plugin/instance.rb:745:in instance_eval’
/var/www/discourse/lib/plugin/instance.rb:745:in activate!' /var/www/discourse/lib/discourse.rb:347:in block in activate_plugins!’
/var/www/discourse/lib/discourse.rb:344:in each' /var/www/discourse/lib/discourse.rb:344:in activate_plugins!’
/var/www/discourse/config/application.rb:227:in block in <class:Application>' /var/www/discourse/lib/plugin.rb:6:in initialization_guard’
/var/www/discourse/config/application.rb:227:in <class:Application>' /var/www/discourse/config/application.rb:75:in module:Discourse’
/var/www/discourse/config/application.rb:74:in <top (required)>' <internal:/usr/local/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:38:in require’
internal:/usr/local/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb:38:in require' /var/www/discourse/Rakefile:7:in <top (required)>’
/var/www/discourse/vendor/bundle/ruby/3.2.0/gems/rake-13.1.0/exe/rake:27:in <top (required)>' /usr/local/bin/bundle:25:in load’
/usr/local/bin/bundle:25:in `’
(See full trace by running task with --trace)
I, [2023-12-08T02:58:41.050511 #1] INFO – : gem install tokenizers -v 0.3.3 -i /var/www/discourse/plugins/discourse-ai/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed tokenizers-0.3.3-x86_64-linux
1 gem installed
gem install tiktoken_ruby -v 0.0.5 -i /var/www/discourse/plugins/discourse-ai/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed tiktoken_ruby-0.0.5-x86_64-linux
1 gem installed
gem install iso8601 -v 0.13.0 -i /var/www/discourse/plugins/discourse-automation/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed iso8601-0.13.0
1 gem installed
gem install rrule -v 0.4.4 -i /var/www/discourse/plugins/discourse-automation/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed rrule-0.4.4
1 gem installed
gem install rrule -v 0.4.4 -i /var/www/discourse/plugins/discourse-calendar/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed rrule-0.4.4
1 gem installed
gem install multipart-post -v 2.3.0 -i /var/www/discourse/plugins/discourse-chatbot/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed multipart-post-2.3.0
1 gem installed
gem install faraday-multipart -v 1.0.4 -i /var/www/discourse/plugins/discourse-chatbot/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed faraday-multipart-1.0.4
1 gem installed
gem install event_stream_parser -v 1.0.0 -i /var/www/discourse/plugins/discourse-chatbot/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed event_stream_parser-1.0.0
1 gem installed
gem install ruby-openai -v 6.3.1 -i /var/www/discourse/plugins/discourse-chatbot/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed ruby-openai-6.3.1
1 gem installed
gem install google_search_results -v 2.2.0 -i /var/www/discourse/plugins/discourse-chatbot/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed google_search_results-2.2.0
1 gem installed
gem install wikipedia-client -v 1.17.0 -i /var/www/discourse/plugins/discourse-chatbot/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed wikipedia-client-1.17.0
1 gem installed
gem install childprocess -v 4.1.0 -i /var/www/discourse/plugins/discourse-chatbot/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed childprocess-4.1.0
1 gem installed
gem install safe_ruby -v 1.0.4 -i /var/www/discourse/plugins/discourse-chatbot/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed safe_ruby-1.0.4
1 gem installed
gem install liquid -v 5.0.1 -i /var/www/discourse/plugins/discourse-custom-wizard/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed liquid-5.0.1
1 gem installed
gem install discourse_subscription_client -v 0.1.1 -i /var/www/discourse/plugins/discourse-custom-wizard/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed discourse_subscription_client-0.1.1
1 gem installed
gem install discourse_plugin_statistics -v 0.1.0.pre7 -i /var/www/discourse/plugins/discourse-custom-wizard/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed discourse_plugin_statistics-0.1.0.pre7
1 gem installed
gem install geocoder -v 1.8.2 -i /var/www/discourse/plugins/discourse-locations/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed geocoder-1.8.2
1 gem installed
gem install discourse_subscription_client -v 0.1.0.pre15 -i /var/www/discourse/plugins/discourse-subscription-client/gems/3.2.2 --no-document --ignore-dependencies --no-user-install
Successfully installed discourse_subscription_client-0.1.0.pre15
1 gem installed

FAILED

Pups::ExecError: cd /var/www/discourse && su discourse -c ‘bundle exec rake db:migrate’ failed with return #<Process::Status: pid 3704 exit 1>
Location of failure: /usr/local/lib/ruby/gems/3.2.0/gems/pups-1.2.1/lib/pups/exec_command.rb:132:in `spawn’
exec failed with the params {“cd”=>“$home”, “hook”=>“db_migrate”, “cmd”=>[“su discourse -c ‘bundle exec rake db:migrate’”]}
bootstrap failed with exit code 1

[richard]

You need to remove the subscription-client plugin, it has been incorporated in the custom wizard plugin.

[davidkingham]

Okay that worked, may I ask why this wasn’t communicated to clients?

[NathanK]

Sorry for the inconvenience it caused you; I know that rebuild failures aren’t a lot of fun! We really appreciate you reporting it so promptly.

There was an unanticipated clash between the (now deprecated) Subscription Client and the latest Custom Wizard Plugin build that caused the rebuild failure. The quick solution in your case was to remove the Client.

The underlying problem has now been fixed, so rebuilds should be fine for all subscribers now. They will receive a deprecation notice on the Wizard admin page, guiding them to remove the Client plugin in the future.

[richard]

@davidkingham

may I ask why this wasn’t communicated to clients?

Simply put: you beat us to it. We did not realize that there would be a conflict. I found out a few hours after you did because my daily automated rebuild failed and when I headed here to address it, I found your post.

[davidkingham]

Fair enough! The quick answer made me think this was a known problem, no worries then.