Failing test on Custom Wizard

Support Discourse Custom Wizard
,
1

We probably shouldn’t be merging with a failing test?:

image
image1031×793 57.9 KB

Failures:

  1) CustomWizard::StepsController with user raises an error when the user cant access the wizard
     Failure/Error: expect(response.status).to eq(403)
     
       expected: 403
            got: 200
     
       (compared using ==)
     # ./plugins/discourse-custom-wizard/spec/requests/custom_wizard/steps_controller_spec.rb:145:in `block (4 levels) in <main>'
     # ./spec/rails_helper.rb:525:in `block (3 levels) in <top (required)>'
     # ./spec/rails_helper.rb:515:in `block (2 levels) in <top (required)>'
     # ./spec/rails_helper.rb:472:in `block (2 levels) in <top (required)>'
2

That said, @angus added me to a review for a PR that is unrelated, so I’ve gone ahead and merged - we still need to resolve this issue though!

@jumagura do you have any capacity to take a look?

1 Like
3

Hi Robert

This change should fix the problem.

Details of the fix are in the PR comment

2 Likes
4

Thanks @jumagura I’ll take a look!

5

Thanks @jumagura !

This is reviewed & merged and now we have a passing suite of tests again! :rocket:

2 Likes