system
November 16, 2023, 12:07am
1
Discourse Custom Wizard either has a bug, or is incompatible with the Discourse commit linked below.
Time: 2023-11-16T00:07:42+00:00ci / frontend_tests has failed: QUnit Test Failure: Acceptance: Field | Fields: Composer - Hyperlink, Process completed with exit code 1.
Branch: tests-passed
Branch: main
richard
November 16, 2023, 10:22am
2
Re-ran the tests, still failing.
Ah so this is not my PR! It’s failing in my PR too. (Which was holding up the PR!)
If I solve this for my PR and it is merged this issue will be resolved
I believe I know why this is happening, and it’s down to an unresolved deprecation which is causing the composer banner not to appear.
I’m on it.
No, that’s only part of it.
It’s because of the new Glimmer Composer with Topic Template functionality I suspect … still looking.
This is all fixed as part of my huge PR:
paviliondev:main ← paviliondev:use_subscription_gem
opened 06:25AM - 08 Sep 23 UTC
* IMPROVE: moves CW to rely on referenced gem instead of Subscription Client, so… it can run entirely independently.
* IMPROVE: rationalises and consolidates subscription logic somewhat:
* COMPATIBILITY: moves FE subscriptions management to a Service (in part because Mixins are deprecated)
* IMPROVE: moves subscription serialisation to a dedicated controller on the BE.
* COMPATIBILITY: converts several related Components to Glimmer (and colocates template files as per standard).
* alters the way subscription client is mocked up in tests to accommodate the fact that overriding the class does not work the same way now that we've added the gem
* adds FE tests for Authorization and Subscription status.
* COMPATIBILITY: fixes deprecation of registerUnbound with Wizard Char Counter
* FIX: non working FE tests because of refactor of Core Composer has changed CSS selectors.
* IMPROVE: moves Pavilion icon to standard SVG registration system (from ad hoc template addition).
system
November 17, 2023, 1:11pm
7
Discourse Custom Wizard has recovered from this issue.