Discourse Custom Wizard main does not work on tests-passed

system · November 16, 2023, 12:07am

Discourse Custom Wizard either has a bug, or is incompatible with the Discourse commit linked below.

Time: 2023-11-16T00:07:42+00:00
Message: ci / frontend_tests has failed: QUnit Test Failure: Acceptance: Field | Fields: Composer - Hyperlink, Process completed with exit code 1.

Discourse

Branch: tests-passed
SHA:

Plugin

Branch: main
SHA:

Details

richard · November 16, 2023, 10:22am

Re-ran the tests, still failing.

merefield · November 16, 2023, 1:49pm

Ah so this is not my PR! It’s failing in my PR too. (Which was holding up the PR!)

If I solve this for my PR and it is merged this issue will be resolved

merefield · November 16, 2023, 3:18pm

I believe I know why this is happening, and it’s down to an unresolved deprecation which is causing the composer banner not to appear.

I’m on it.

merefield · November 16, 2023, 3:58pm

No, that’s only part of it.

It’s because of the new Glimmer Composer with Topic Template functionality I suspect … still looking.

merefield · November 16, 2023, 6:01pm

This is all fixed as part of my huge PR:

github.com/paviliondev/discourse-custom-wizard

DEV: switch to using subscription gem to avoid the need to rely on Subscription Client plugin

paviliondev:main ← paviliondev:use_subscription_gem

opened 06:25AM - 08 Sep 23 UTC

merefield

+651 -289

* IMPROVE: moves CW to rely on referenced gem instead of Subscription Client, so… it can run entirely independently. * IMPROVE: rationalises and consolidates subscription logic somewhat: * COMPATIBILITY: moves FE subscriptions management to a Service (in part because Mixins are deprecated) * IMPROVE: moves subscription serialisation to a dedicated controller on the BE. * COMPATIBILITY: converts several related Components to Glimmer (and colocates template files as per standard). * alters the way subscription client is mocked up in tests to accommodate the fact that overriding the class does not work the same way now that we've added the gem * adds FE tests for Authorization and Subscription status. * COMPATIBILITY: fixes deprecation of registerUnbound with Wizard Char Counter * FIX: non working FE tests because of refactor of Core Composer has changed CSS selectors. * IMPROVE: moves Pavilion icon to standard SVG registration system (from ad hoc template addition).

system · November 17, 2023, 1:11pm

Discourse Custom Wizard has recovered from this issue.