Discourse Custom Wizard main does not work on tests-passed

Support Discourse Custom Wizard
, ,
1

Discourse Custom Wizard either has a bug, or is incompatible with the Discourse commit linked below.

Time: 2023-05-31T00:11:27+00:00
Message: ci / backend_tests has failed: Process completed with exit code 1.

Discourse

Branch: tests-passed
SHA:

Plugin

Branch: main
SHA:

Details

2

I have no idea why this is sometimes failing and often not.

Failures:

  1) CustomWizard::AdminController with an admin without a subscription returns the right subscription details
     Failure/Error: expect(response.parsed_body["subscription_client_installed"]).to eq(false)
     
       expected: false
            got: true
     
       (compared using ==)
     
       Diff:
       @@ -1 +1 @@
       -false
       +true
       
     # ./plugins/discourse-custom-wizard/spec/requests/custom_wizard/admin/admin_controller_spec.rb:21:in `block (4 levels) in <main>'
     # ./spec/rails_helper.rb:372:in `block (3 levels) in <top (required)>'
     # ./spec/rails_helper.rb:367:in `block (2 levels) in <top (required)>'
     # ./spec/rails_helper.rb:356:in `block (2 levels) in <top (required)>'

@angus @merefield ?

4

Taking a look.

5

@richard if a spec fails sometimes and not others it’s almost always because something is stubbed or CRUD’d in another spec when the failing spec assumes it’s operating in isolation. I suspect this will fix it.

1 Like
6

Discourse Custom Wizard has recovered from this issue.

7